-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO Tools: support taxonomy archive pages in page titles. #12425
Conversation
The SEO Tools allows you to set a custom title for different types of pages, from your WordPress.com dashboard. However, once you've done that and when viewing a taxonomy archive page, you get an incomplete title. This fixes is, since taxonomy archive pages are very similar to non-custom taxonomy archive pages like category or tag pages.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Changes proposed in this Pull Request:
The SEO Tools allows you to set a custom title for different types of pages, from your WordPress.com dashboard.
However, once you've done that and when viewing a taxonomy archive page, you get an incomplete title. This fixes is, since taxonomy archive pages are very similar to non-custom taxonomy archive pages like category or tag pages.
Testing instructions:
Install a plugin that adds a custom taxonomy to your site.
Purchase a Professional plan.
Go to Tools > Marketing in Calypso.
Create some custom titles like so:
Visit one of the taxonomy archive pages on your site. You will see this:
Apply patch and refresh the page; you should see this:
Proposed changelog entry for your changes: